[1340] Disable git labels if BUILDX_GIT_LABELS is not 1 or full#1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Gageot <david.gageot@docker.com>
crazy-max
approved these changes
Oct 4, 2022
|
LGTM. Thanks for the improvement. |
tonistiigi
reviewed
Oct 6, 2022
| v, ok := os.LookupEnv("BUILDX_GIT_LABELS") | ||
| if !ok || contextPath == "" { | ||
| v := os.Getenv("BUILDX_GIT_LABELS") | ||
| if (v != "1" && v != "full") || contextPath == "" { |
There was a problem hiding this comment.
Could we just do strconv.ParseBool in here like we do in some other places?
@cdupuis Do you need this string "full" for something?
There was a problem hiding this comment.
Setting the env var to full will include the repository url. We did this so that there's a way to not leak repository names but still include commit sha.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make sure that
BUILDX_GIT_LABELS= docker buildx build ...will not set the git labels.Fixes #1340
Signed-off-by: David Gageot david.gageot@docker.com