feat: add resources handling to kubernetes driver#618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalAugustyn
force-pushed
the
handle-resources
branch
from
78ee925
to
826f0db
Compare
AkihiroSuda
reviewed
May 25, 2021
AkihiroSuda
added
kind/enhancement
MichalAugustyn
force-pushed
the
handle-resources
branch
from
826f0db
to
348d2e7
Compare
Signed-off-by: Michal Augustyn <michal.augustyn@mail.com>
MichalAugustyn
force-pushed
the
handle-resources
branch
from
348d2e7
to
a53e392
Compare
AkihiroSuda
approved these changes
May 29, 2021
This was referenced Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers #210.
I have tried to add a single
resourcesdriver-opt at first which could be used as following:But then found out its not possible to nest keyvalues inside driver-opts at the moment (raised an issue for that #617)
The next step could be #377 where it was proposed to add a possibility of extending the YAML manifest.
I might take care of that later, but decided to add resource handling in a simple way for now.