Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker fails to start after upgrade: ArgumentNullException for path1 in Path.Combine#4343

Closed
2 tasks done
heaths opened this issue Jul 31, 2019 · 13 comments
Closed
2 tasks done

Docker fails to start after upgrade: ArgumentNullException for path1 in Path.Combine #4343

heaths opened this issue Jul 31, 2019 · 13 comments
Labels
lifecycle/locked status/acknowledged

Comments

@heaths
Copy link

heaths commented Jul 31, 2019

  • I have tried with the latest version of my channel (Stable or Edge)
  • I have uploaded Diagnostics
  • Diagnostics ID: 099D6802-78A9-4C31-A4CE-18370DCC4A36/20190731181045

Expected behavior

Docker starts successfully.

Actual behavior

Docker fails to start with the following stack:

Value cannot be null.
Parameter name: path1
   at System.IO.Path.Combine(String path1, String path2, String path3)
   at Docker.Core.DynamicPaths.GetPkiFolder(Settings settings)
   at Docker.Backend.Processes.ApiProxy.CommonArgs(Settings settings)
   at Docker.Backend.Processes.ApiProxy.StartWinNamedPipe(Settings settings, String daemonNamedPipe, Boolean runAsSystem)
   at Docker.Backend.ContainerEngine.Windows.DoStart(Settings settings, String daemonOptions)
   at Docker.Backend.ContainerEngine.Windows.Start(Settings settings, String daemonOptions, Credential credential)
   at Docker.Backend.BackendNamedPipeServer.<Run>b__8_4(Object[] args)
   at Docker.Core.Pipe.NamedPipeServer.<>c__DisplayClass9_0.<Register>b__0(Object[] parameters)
   at Docker.Core.Pipe.NamedPipeServer.RunAction(String action, Object[] parameters)

Information

  • Windows Version: Windows 10 version 1903 build 18362.267
  • Docker Desktop Version: Docker version 19.03.1, build 74b1e89

Steps to reproduce the behavior

  1. Try to start "Docker for Windows".

FWIW, I do have and have had (for a couple years) a custom location and daemon.json file in %ProgramData%\Docker\config\daemon.json like so:

{
  "registry-mirrors": [],
  "insecure-registries": [],
  "debug": true,
  "experimental": true,
  "graph": "E:\\Docker",
  "hosts": [
    "npipe://"
  ],
  "storage-opts": [
    "size=127G"
  ]
}

My machine is also a swarm manager with a separate VM running on my machine that is joined to the swarm (testing out scenarios on a pretty beefy dev machine). Everything was working fine before the upgrade.
@BSSIRajbir
Copy link

The same thing Happened on My Window just after the update.

@mschonwe
Copy link

Same error here too.

@heaths
Copy link
Author

heaths commented Jul 31, 2019

For those having similar issues, using the +1 reaction on the OP might make it easier for support to view the discussion and get a better sense of how many others are having the same issue. 😉

@Robot1que
Copy link

Docker does not crash anymore after uninstalling and installing the latest version.

@mikeparker
Copy link
Contributor

I think this is because settings.json has a "dataFolder" : null entry. Could you check please?

@mikeparker
Copy link
Contributor

Also could you confirm if this is on stable or edge release?

@mschonwe
Copy link

mschonwe commented Aug 1, 2019

The contents of C:\ProgramData\Docker\config\daemon.json is:

{"registry-mirrors":[],"insecure-registries":[], "debug":true, "experimental": false}

Not sure about stable vs edge, File Version : 2.1.0.36874

@mikeparker
Copy link
Contributor

mikeparker commented Aug 1, 2019 •
edited
Loading

Looks like its the same issue as #3375 which got closed as stale but didn't get fixed. Will fix now.

The settings file is at C:\Users<username>\AppData\Roaming\Docker\settings.json usually

Stable vs Edge you can check by going to the whale menu in the systray and clicking About Docker Desktop, it's listed under Channel.

@mschonwe
Copy link

mschonwe commented Aug 1, 2019

The crash error prevents the whale menu from appearing in the systray.

Editing the settings file is at C:\Users\AppData\Roaming\Docker\settings.json to change "dataFolder" : null to "dataFolder" : "", prevents the crash.

Oddly the first time I made this change, I got a red whale with a path warning error. I changed it back to null to see if the systray icon would appear (it didn't). Then when changing back to "dataFolder" : "" and starting, it started w/o any errors at all.

Now that it is running, I can confirm this is on stable release.

@mikeparker
Copy link
Contributor

Great, thanks!

@mikeparker
Copy link
Contributor

To confirm, this is a duplicate of #3375 so i'm closing, but we are fixing the root cause. Please see #3375 (comment) for a workaround.

@mikeparker mikeparker changed the title Docker fails to start after upgrade: ArgumentNullException in Path.Combine Docker fails to start after upgrade: ArgumentNullException for path1 in Path.Combine Aug 6, 2019
@usha-mandya usha-mandya mentioned this issue Aug 7, 2019
Merged
@mikeparker
Copy link
Contributor

Docker Desktop 2.1.0.1 stable has been released with a fix for this now.

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle locked

@docker docker locked and limited conversation to collaborators Jul 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
lifecycle/locked status/acknowledged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests

6 participants
@mschonwe @heaths @mikeparker @Robot1que @docker-robott @BSSIRajbir