!env for respecting environment variables from the configuration file#1524
Conversation
| env_var_content = ""; | ||
|
|
||
| free(node->data.scalar); | ||
| node->data.scalar = h2o_strdup(NULL, env_var_content, SIZE_MAX).base; |
There was a problem hiding this comment.
what is the reason the pointer from getenv cant be assigned directly to node->data.scalar ?
There was a problem hiding this comment.
Because node->data.scalar eventually gets freed in yoml_free.
|
Q: should we allow a default value? if so how, just |
Could you please elaborate what you mean by "default"? To me the current code that uses an empty string upon the absence the environment variable seems sufficient to me. |
|
@kazuho one could catch the null and then set the variable to a default that was supplied. Like If you think thats useless im fine as is. Use case for me would be to simplify deployment of mini services in containers |
|
@yannick Sorry for the belated response.
We could do that, but the syntax could be an issue. Personally I'd prefer using a syntax similar to bash (e.g., What do you think? Alternatively, we could leave default value support to another PR. |
|
@kazuho i am fine with this idea. i'd say we leave it as is and if i manage i'll do a 2nd pr to add defaults. |
|
Thank you for working on the PR. The changes have been merged to master. |
kazuho
changed the title
!env for respecting environment variables from the configuration file
implements #1520 , replaces #1519