-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only preload resources with matching type/as attributes#7851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch
|
||
<ul class="brief"> | ||
<li><p><var>destination</var> is <code data-x="">audio</code> or <code data-x="">video</code>, | ||
and <var>mimeTypeRecord</var> is an <span>audio or video MIME type</span></p></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We allow using as=audio type=video/blah
?? That's a bit surprising... is it tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's expected since audio elements can play video tracks and vice versa.
I wasn't able to test media preloading reliably yet though, due to range responses, regardless of type verification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would feel more comfortable merging this if we had some confirmation (e.g. by codebase inspection or via @annevk testimony, if we can't manage WPTs) that this was the desired behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I inspected the Chromium and WebKit code bases and this is based on that inspection.
Closes w3c/preload#113
(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/links.html ( diff )
/semantics.html ( diff )