Page MenuHomePhabricator
Create Task
Maniphest T109121

Remove deprecated pear/mail_mime-decode
Closed, ResolvedPublic
Actions

Description

From https://packagist.org/packages/pear/mail_mime-decode

The maintainer wrote:

This library is quite old and was being used by our software. We are no longer using it, and thus, no longer maintaining this repository. It will be removed later this year (Q4 2015). Please find an alternate source or fork your own copy. Thanks!

Details

SubjectRepoBranchLines +/-
Remove deprecated pear/mail_mime-decode from composer dependanciesmediawiki/coreREL1_31+1 -1
Remove deprecated pear/mail_mime-decode from composer suggestionsmediawiki/coreREL1_27+1 -1
Remove pear/mail_mime-decodemediawiki/vendorREL1_31+13 -1 K
Remove pear/mail_mime-decodemediawiki/vendorREL1_27+924 -2 K
Remove deprecated pear/mail_mime-decode from composer suggestionsmediawiki/coreREL1_30+1 -1
Remove pear/mail_mime-decodemediawiki/vendorREL1_30+13 -1 K
Remove pear/mail_mime-decodemediawiki/vendormaster+2 -1 K
Remove pear/mail_mime-decodemediawiki/vendormaster+1 -1 K
Remove pear/mail_mime-decodemediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Aug 14 2015, 6:52 PM
Reedy raised the priority of this task from to Needs Triage.
Reedy updated the task description. (Show Details)
Reedy added projects: Librarization, MediaWiki-Email.
Reedy subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 14 2015, 6:52 PM
01tonythomas subscribed.Aug 14 2015, 6:58 PM
This comment was removed by 01tonythomas.
01tonythomas added a comment.Aug 14 2015, 7:01 PM

Removed my comment.
I thought they were dropping support for pear/php-mailer

Reedy added a comment.Aug 14 2015, 7:07 PM
In T109121#1540794, @01tonythomas wrote:

Removed my comment.
I thought they were dropping support for pear/php-mailer

mail sucks in mediawiki anyway :D

01tonythomas added a comment.Aug 14 2015, 7:09 PM

Yeah - I was mentioning https://www.mediawiki.org/wiki/Extension:SwiftMailer

Aklapper added a project: Technical-Debt.Aug 15 2015, 10:40 AM
Danny_B moved this task from Unsorted to Needs research on the Technical-Debt board.Jan 23 2016, 9:57 AM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptJan 23 2016, 9:57 AM
01tonythomas added a comment.Mar 8 2016, 4:56 PM

Do we still use mail_mime-decode ?

I search for Mail_mime-decode, https://github.com/wikimedia/mediawiki/search?utf8=%E2%9C%93&q=Mail_mimeDecode&type=Code and hit nothing ?

BPirkle subscribed.Oct 10 2018, 4:43 PM

I also did not find anywhere that we are using this, and the issue description says it will be removed Q4 2015. Per https://phabricator.wikimedia.org/T173849, it has PHP 7 compatibility issues. Is there any reason we should not go ahead and remove it?

Reedy added a comment.EditedOct 10 2018, 5:38 PM
In T109121#4655407, @BPirkle wrote:

I also did not find anywhere that we are using this, and the issue description says it will be removed Q4 2015. Per https://phabricator.wikimedia.org/T173849, it has PHP 7 compatibility issues. Is there any reason we should not go ahead and remove it?

FYI, it's better to use T173849 rather than https://phabricator.wikimedia.org/T173849 when using Phabricator. That way it keeps track of which tickets reference each other

As far as I can see, the code is basically orphaned and unused in MW core. Mail_mime and Mail_mimePart seem to be duplicated against pear/mail...

Patches incoming!

gerritbot subscribed.Oct 10 2018, 5:40 PM

Change 465669 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@master] Remove pear/mail_mime-decode

https://gerrit.wikimedia.org/r/465669

gerritbot added a project: Patch-For-Review.Oct 10 2018, 5:40 PM

Change 465670 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Remove pear/mail_mime-decode

https://gerrit.wikimedia.org/r/465670

Reedy renamed this task from Look for replacement for deprecated pear/mail_mime-decode to Remove deprecated pear/mail_mime-decode.Oct 10 2018, 5:42 PM
gerritbot added a comment.Oct 10 2018, 8:58 PM

Change 465670 merged by jenkins-bot:
[mediawiki/core@master] Remove pear/mail_mime-decode

https://gerrit.wikimedia.org/r/465670

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 10 2018, 9:00 PM
Krinkle updated the task description. (Show Details)Oct 10 2018, 9:58 PM
gerritbot added a comment.Oct 11 2018, 8:36 PM

Change 465669 merged by jenkins-bot:
[mediawiki/vendor@master] Remove pear/mail_mime-decode

https://gerrit.wikimedia.org/r/465669

Reedy closed this task as Resolved.Oct 11 2018, 8:36 PM
Reedy claimed this task.
Reedy removed a project: Patch-For-Review.
gerritbot added a comment.Oct 11 2018, 8:42 PM

Change 466771 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_27] Remove deprecated pear/mail_mime-decode from composer suggestions

https://gerrit.wikimedia.org/r/466771

gerritbot added a project: Patch-For-Review.Oct 11 2018, 8:42 PM

Change 466772 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_30] Remove deprecated pear/mail_mime-decode from composer suggestions

https://gerrit.wikimedia.org/r/466772

gerritbot added a comment.Oct 11 2018, 8:46 PM

Change 466775 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_31] Remove deprecated pear/mail_mime-decode from composer dependancies

https://gerrit.wikimedia.org/r/466775

gerritbot added a comment.Oct 11 2018, 8:51 PM

Change 466776 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@master] Remove pear/mail_mime-decode

https://gerrit.wikimedia.org/r/466776

gerritbot added a comment.Oct 11 2018, 8:53 PM

Change 466776 abandoned by Reedy:
Remove pear/mail_mime-decode

https://gerrit.wikimedia.org/r/466776

gerritbot added a comment.Oct 11 2018, 8:55 PM

Change 466779 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@REL1_31] Remove pear/mail_mime-decode

https://gerrit.wikimedia.org/r/466779

gerritbot added a comment.Oct 11 2018, 8:56 PM

Change 466780 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@REL1_30] Remove pear/mail_mime-decode

https://gerrit.wikimedia.org/r/466780

Reedy reopened this task as Open.Oct 11 2018, 9:01 PM

Worth clearing it up in supported branches too, so hence the patches above

gerritbot added a comment.Oct 11 2018, 9:52 PM

Change 466797 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/vendor@REL1_27] Remove pear/mail_mime-decode

https://gerrit.wikimedia.org/r/466797

gerritbot added a comment.Oct 11 2018, 10:12 PM

Change 466780 merged by jenkins-bot:
[mediawiki/vendor@REL1_30] Remove pear/mail_mime-decode

https://gerrit.wikimedia.org/r/466780

gerritbot added a comment.Oct 11 2018, 10:20 PM

Change 466772 merged by jenkins-bot:
[mediawiki/core@REL1_30] Remove deprecated pear/mail_mime-decode from composer suggestions

https://gerrit.wikimedia.org/r/466772

ReleaseTaggerBot added a project: MW-1.30-release-notes.Oct 11 2018, 11:00 PM
gerritbot added a comment.Oct 11 2018, 11:41 PM

Change 466797 merged by jenkins-bot:
[mediawiki/vendor@REL1_27] Remove pear/mail_mime-decode

https://gerrit.wikimedia.org/r/466797

gerritbot added a comment.Oct 11 2018, 11:41 PM

Change 466779 merged by jenkins-bot:
[mediawiki/vendor@REL1_31] Remove pear/mail_mime-decode

https://gerrit.wikimedia.org/r/466779

gerritbot added a comment.Oct 12 2018, 12:30 AM

Change 466771 merged by jenkins-bot:
[mediawiki/core@REL1_27] Remove deprecated pear/mail_mime-decode from composer suggestions

https://gerrit.wikimedia.org/r/466771

gerritbot added a comment.Oct 12 2018, 12:32 AM

Change 466775 merged by jenkins-bot:
[mediawiki/core@REL1_31] Remove deprecated pear/mail_mime-decode from composer dependancies

https://gerrit.wikimedia.org/r/466775

ReleaseTaggerBot added projects: MW-1.31-release-notes, MW-1.27-release-notes.Oct 12 2018, 1:00 AM
BPirkle mentioned this in T173849: Possible PHP7 compatibility issues in mediawiki/vendor.Oct 12 2018, 4:12 AM
Reedy closed this task as Resolved.Oct 12 2018, 11:57 AM
Reedy removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits