The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: alexstine <alexstine@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>
Co-authored-by: joedolson <joedolson@git.wordpress.org>
Co-authored-by: pablohoneyhoney <pablohoneyhoney@git.wordpress.org>
Co-authored-by: SaxonF <saxonafletcher@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Size Change: +4.01 kB (+0.23%)

Total Size: 1.75 MB

_{compressed-size-action}

So excited to see this being worked on! Minor but, for consistency's sake, can we update this to "Add new pattern"? For context:

In reading through #58198, it seems like we're trying to move towards "Add new" which this doesn't do as well. As a result, for now, I'd argue for having it as "Add new pattern" and then updating all to "Add new" or whatever is decided upon in the future cc @jameskoster for a confidence check.

It should probably read "Add pattern"—but I'm also not 100% about this big primary buttons to be honest. It's the same style as the save buttons, in nearly the same position; I think it makes the experience less predictable.

And also, do we have a pattern of using a primary button as a popover container? Feels a bit unexpected, as every other primary button is a key action taken, not leading to a post-selection decision.

Curious what @WordPress/gutenberg-design thinks as well.

Based on the discussion in #58198, it seems like "Add new pattern" makes more sense than "Create pattern" following the logic in the core. In that case, should the popover menu items also be unified with "Add new"?

As mentioned in ToDo #58198, I think all additional buttons should eventually be replaced with secondary variations. Also, since the current button size is 36px, we should also consider that it will be updated to a standard size of 24px/32px/40px in the future.

As for the button itself, it looks like its position is slightly shifted upwards compared to other buttons, so we may need to adjust the CSS.

I updated the button's variant to secondary and the copy to add new pattern. Any more feedback is welcome to consolidate all these 'add new' buttons.

It should probably read "Add pattern"—but I'm also not 100% about this big primary buttons to be honest. It's the same style as the save buttons, in nearly the same position; I think it makes the experience less predictable.

And also, do we have a pattern of using a primary button as a popover container? Feels a bit unexpected, as every other primary button is a key action taken, not leading to a post-selection decision.

Agree with this. "Add Template Part" gets verbose too, probably in translations too, it doesn't feel the most scalable pattern.

@jasmussen, I think we need to keep "what" in the button labels. See #58198 (comment) and #58198 (comment).

@ntsekouras, I think the label casing should match the other pages.

The UX is very different from other "Add New" buttons. Maybe instead of a dropdown, we should display a new pattern modal?

I don't have a strong opinion about the button labels, except that they should be consistent. "Add x" seems fine to me.

I agree the button opening a menu is a bit clunky, but I think that's a short-term thing until patterns and templates converge more comprehensively. If it's a big deal, then we could try a split-button, as we've been exploring for save + publish:

Eventually it should just open the 'Add pattern' UX (modal), and importing should probably be a secondary (or even tertiary) action.

Speaking of secondary actions, if we keep the blue primary variant here then we can employ a pattern like this later which feels important:

Buttons/links must have enough context for users. Add New is not good enough for accessibility, it's why we changed all of them in Core. I am good with Add New X or Add X but not just Add or Add New.

https://www.w3.org/WAI/WCAG21/Understanding/link-purpose-in-context.html

This applies more to links over buttons but I think we should keep the same patterns for UI/UX consistency.

Thanks.

This should be ready for another round of reviews, based on the updated description of the main issue.

I can extract the labels update to remove the new for other post types too in a separate PR, to address https://core.trac.wordpress.org/ticket/61219#ticket.

Flaky tests detected in a629e26.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9175329171
📝 Reported issues:

• [Flaky Test] Clicking on inserter while on zoom-out should open the patterns tab on the inserter #61806 in /test/e2e/specs/site-editor/zoom-out.spec.js

It would be really nice to use DropdownMenu V2 here (#61094). Fine to do that later/separately if it's not trivial.