Properly account for `this` argument in intersection apparent type caching#58677

ahejlsberg · 2024-05-28T15:07:36Z

ahejlsberg · 2024-05-28T15:08:10Z

Will add regression tests later today.

ahejlsberg · 2024-05-28T15:08:19Z

typescript-bot · 2024-05-28T15:08:22Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-05-28T15:34:05Z

Hey @ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-05-28T15:35:09Z

@ahejlsberg Here are the results of running the user tests comparing main and refs/pull/58677/merge:

Everything looks good!

typescript-bot · 2024-05-28T15:50:54Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,248	_50,248	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,997k (± 0.76%)}	_{193,462k (± 0.96%)}	_~	_192,222k	_195,907k	_{p=1.000 n=6}
_{Parse Time}	_{1.30s (± 0.42%)}	_{1.30s (± 0.69%)}	_~	_1.29s	_1.31s	_{p=0.341 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.58s (± 0.56%)}	_{9.55s (± 0.35%)}	_~	_9.51s	_9.60s	_{p=0.377 n=6}
_{Emit Time}	_{2.64s (± 0.75%)}	_{2.63s (± 1.19%)}	_~	_2.60s	_2.69s	_{p=0.370 n=6}
_{Total Time}	_{14.24s (± 0.40%)}	_{14.20s (± 0.28%)}	_~	_14.15s	_14.25s	_{p=0.334 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,110	_944,110	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,140	_407,140	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,052k (± 0.00%)}	_{1,222,120k (± 0.00%)}	_{+69k (+ 0.01%)}	_1,222,058k	_1,222,161k	_{p=0.013 n=6}
_{Parse Time}	_{6.78s (± 0.78%)}	_{6.78s (± 0.56%)}	_~	_6.75s	_6.85s	_{p=1.000 n=6}
_{Bind Time}	_{1.88s (± 0.45%)}	_{1.87s (± 0.55%)}	_~	_1.86s	_1.89s	_{p=0.672 n=6}
_{Check Time}	_{31.35s (± 0.20%)}	_{31.43s (± 0.47%)}	_~	_31.23s	_31.64s	_{p=0.377 n=6}
_{Emit Time}	_{14.73s (± 0.38%)}	_{14.70s (± 0.73%)}	_~	_14.51s	_14.78s	_{p=0.810 n=6}
_{Total Time}	_{54.74s (± 0.14%)}	_{54.78s (± 0.38%)}	_~	_54.49s	_55.04s	_{p=0.810 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,983,044	_1,983,044	_~	_~	_~	_{p=1.000 n=6}
_Types	_881,266	_881,266	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,888,244k (± 0.00%)}	_{1,888,993k (± 0.00%)}	_{+749k (+ 0.04%)}	_1,888,939k	_1,889,103k	_{p=0.005 n=6}
_{Parse Time}	_{6.82s (± 0.39%)}	_{6.83s (± 0.40%)}	_~	_6.79s	_6.87s	_{p=0.570 n=6}
_{Bind Time}	_{2.27s (± 0.96%)}	_{2.30s (± 0.85%)}	_{+0.03s (+ 1.47%)}	_2.27s	_2.32s	_{p=0.032 n=6}
_{Check Time}	_{60.53s (± 0.24%)}	_{61.20s (± 0.38%)}	_{+0.67s (+ 1.11%)}	_60.99s	_61.52s	_{p=0.005 n=6}
_{Emit Time}	_0.14s	_0.14s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{69.76s (± 0.22%)}	_{70.47s (± 0.34%)}	_{+0.71s (+ 1.02%)}	_70.24s	_70.79s	_{p=0.005 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,341	_1,226,342	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,978	_260,978	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,368,829k (± 2.59%)}	_{2,342,955k (± 0.05%)}	_~	_2,341,929k	_2,345,240k	_{p=0.093 n=6}
_{Parse Time}	_{4.98s (± 0.66%)}	_{5.00s (± 0.77%)}	_~	_4.96s	_5.06s	_{p=0.630 n=6}
_{Bind Time}	_{1.92s (± 0.77%)}	_{1.92s (± 0.63%)}	_~	_1.90s	_1.93s	_{p=0.739 n=6}
_{Check Time}	_{33.85s (± 0.30%)}	_{33.89s (± 0.31%)}	_~	_33.75s	_34.07s	_{p=0.689 n=6}
_{Emit Time}	_{2.58s (± 3.01%)}	_{2.66s (± 5.50%)}	_~	_2.48s	_2.89s	_{p=0.471 n=6}
_{Total Time}	_{43.32s (± 0.26%)}	_{43.49s (± 0.48%)}	_~	_43.15s	_43.74s	_{p=0.173 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,341	_1,226,342	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,978	_260,978	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,470,505k (± 3.13%)}	_{2,444,973k (± 2.52%)}	_~	_2,418,164k	_2,570,928k	_{p=0.298 n=6}
_{Parse Time}	_{6.23s (± 0.85%)}	_{6.23s (± 0.75%)}	_~	_6.15s	_6.28s	_{p=0.936 n=6}
_{Bind Time}	_{2.06s (± 0.91%)}	_{2.05s (± 0.57%)}	_~	_2.04s	_2.07s	_{p=0.290 n=6}
_{Check Time}	_{40.35s (± 0.24%)}	_{40.37s (± 0.26%)}	_~	_40.26s	_40.51s	_{p=1.000 n=6}
_{Emit Time}	_{3.02s (± 2.41%)}	_{3.12s (± 5.08%)}	_~	_2.96s	_3.38s	_{p=0.229 n=6}
_{Total Time}	_{51.66s (± 0.29%)}	_{51.80s (± 0.35%)}	_~	_51.66s	_52.07s	_{p=0.128 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,038	_258,039	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,984	_104,984	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,928k (± 0.02%)}	_{427,122k (± 0.02%)}	_{+194k (+ 0.05%)}	_426,995k	_427,297k	_{p=0.013 n=6}
_{Parse Time}	_{4.13s (± 0.36%)}	_{4.13s (± 0.68%)}	_~	_4.08s	_4.16s	_{p=1.000 n=6}
_{Bind Time}	_{1.61s (± 0.85%)}	_{1.64s (± 1.14%)}	_~	_1.60s	_1.65s	_{p=0.053 n=6}
_{Check Time}	_{22.31s (± 0.35%)}	_{22.36s (± 0.18%)}	_~	_22.31s	_22.40s	_{p=0.333 n=6}
_{Emit Time}	_{1.71s (± 1.21%)}	_{1.68s (± 2.04%)}	_~	_1.65s	_1.73s	_{p=0.228 n=6}
_{Total Time}	_{29.76s (± 0.34%)}	_{29.80s (± 0.14%)}	_~	_29.76s	_29.86s	_{p=0.297 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,575	_224,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,785	_93,785	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,930k (± 0.04%)}	_{369,854k (± 0.04%)}	_~	_369,712k	_370,066k	_{p=0.298 n=6}
_{Parse Time}	_{2.82s (± 1.16%)}	_{2.83s (± 0.89%)}	_~	_2.79s	_2.86s	_{p=0.871 n=6}
_{Bind Time}	_{1.58s (± 0.48%)}	_{1.58s (± 0.57%)}	_~	_1.57s	_1.59s	_{p=0.798 n=6}
_{Check Time}	_{15.64s (± 0.35%)}	_{15.62s (± 0.37%)}	_~	_15.53s	_15.71s	_{p=0.258 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.04s (± 0.22%)}	_{20.02s (± 0.34%)}	_~	_19.97s	_20.15s	_{p=0.421 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,840,563	_2,840,563	_~	_~	_~	_{p=1.000 n=6}
_Types	_963,163	_963,163	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,013,875k (± 0.00%)}	_{3,013,863k (± 0.00%)}	_~	_3,013,784k	_3,013,947k	_{p=1.000 n=6}
_{Parse Time}	_{17.00s (± 0.38%)}	_{16.98s (± 0.51%)}	_~	_16.90s	_17.11s	_{p=0.228 n=6}
_{Bind Time}	_{5.14s (± 2.42%)}	_{5.14s (± 2.21%)}	_~	_5.02s	_5.27s	_{p=1.000 n=6}
_{Check Time}	_{88.60s (± 0.27%)}	_{88.76s (± 0.28%)}	_~	_88.53s	_89.13s	_{p=0.520 n=6}
_{Emit Time}	_{28.61s (± 0.50%)}	_{28.57s (± 0.62%)}	_~	_28.31s	_28.75s	_{p=0.630 n=6}
_{Total Time}	_{139.35s (± 0.28%)}	_{139.45s (± 0.28%)}	_~	_138.99s	_139.95s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,087	_266,087	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,518	_108,518	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,922k (± 0.01%)}	_{411,025k (± 0.03%)}	_~	_410,894k	_411,201k	_{p=0.173 n=6}
_{Parse Time}	_{4.78s (± 0.51%)}	_{4.79s (± 0.54%)}	_~	_4.76s	_4.83s	_{p=0.627 n=6}
_{Bind Time}	_{2.06s (± 1.00%)}	_{2.07s (± 0.56%)}	_~	_2.05s	_2.08s	_{p=0.934 n=6}
_{Check Time}	_{21.05s (± 0.34%)}	_{21.16s (± 0.41%)}	_{+0.11s (+ 0.52%)}	_21.03s	_21.29s	_{p=0.043 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.90s (± 0.24%)}	_{28.02s (± 0.35%)}	_{+0.12s (+ 0.44%)}	_27.86s	_28.15s	_{p=0.036 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_535,745	_535,745	_~	_~	_~	_{p=1.000 n=6}
_Types	_182,753	_182,753	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{470,384k (± 0.00%)}	_{470,488k (± 0.01%)}	_{+104k (+ 0.02%)}	_470,432k	_470,590k	_{p=0.005 n=6}
_{Parse Time}	_{3.18s (± 0.51%)}	_{3.17s (± 0.51%)}	_~	_3.16s	_3.20s	_{p=0.737 n=6}
_{Bind Time}	_{1.21s (± 1.32%)}	_{1.20s (± 0.43%)}	_~	_1.20s	_1.21s	_{p=0.923 n=6}
_{Check Time}	_{18.37s (± 0.32%)}	_{18.39s (± 0.39%)}	_~	_18.31s	_18.52s	_{p=0.808 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.75s (± 0.30%)}	_{22.76s (± 0.31%)}	_~	_22.69s	_22.88s	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-05-28T16:42:28Z

@ahejlsberg Here are the results of running the top 400 repos comparing main and refs/pull/58677/merge:

Everything looks good!

ahejlsberg · 2024-05-28T17:59:03Z

@typescript-bot test it

typescript-bot · 2024-05-28T17:59:06Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-05-28T18:28:50Z

Hey @ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-05-28T18:34:17Z

@ahejlsberg Here are the results of running the user tests comparing main and refs/pull/58677/merge:

Everything looks good!

typescript-bot · 2024-05-28T18:41:22Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,831k (± 0.76%)}	_{192,929k (± 0.73%)}	_~	_192,193k	_195,799k	_{p=0.810 n=6}
_{Parse Time}	_{1.31s (± 0.64%)}	_{1.30s (± 0.76%)}	_~	_1.29s	_1.31s	_{p=0.256 n=6}
_{Bind Time}	_{0.72s (± 0.57%)}	_0.72s	_~	_~	_~	_{p=0.405 n=6}
_{Check Time}	_{9.53s (± 0.28%)}	_{9.54s (± 0.53%)}	_~	_9.46s	_9.59s	_{p=0.629 n=6}
_{Emit Time}	_{2.64s (± 0.59%)}	_{2.64s (± 0.56%)}	_~	_2.62s	_2.65s	_{p=0.801 n=6}
_{Total Time}	_{14.20s (± 0.23%)}	_{14.20s (± 0.43%)}	_~	_14.09s	_14.25s	_{p=0.810 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,105	_944,105	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,032	_407,032	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,221,992k (± 0.01%)}	_{1,222,007k (± 0.01%)}	_~	_1,221,909k	_1,222,080k	_{p=0.936 n=6}
_{Parse Time}	_{8.12s (± 0.25%)}	_{8.11s (± 0.39%)}	_~	_8.08s	_8.16s	_{p=0.684 n=6}
_{Bind Time}	_{2.23s (± 0.59%)}	_{2.25s (± 0.56%)}	_{+0.02s (+ 0.82%)}	_2.23s	_2.26s	_{p=0.048 n=6}
_{Check Time}	_{36.47s (± 0.31%)}	_{36.50s (± 0.45%)}	_~	_36.34s	_36.73s	_{p=0.936 n=6}
_{Emit Time}	_{17.56s (± 0.77%)}	_{17.49s (± 0.42%)}	_~	_17.42s	_17.60s	_{p=0.295 n=6}
_{Total Time}	_{64.38s (± 0.29%)}	_{64.36s (± 0.32%)}	_~	_64.14s	_64.60s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,983,122	_1,983,122	_~	_~	_~	_{p=1.000 n=6}
_Types	_881,307	_881,307	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,888,318k (± 0.00%)}	_{1,888,351k (± 0.00%)}	_~	_1,888,313k	_1,888,407k	_{p=0.173 n=6}
_{Parse Time}	_{6.82s (± 0.36%)}	_{6.83s (± 0.41%)}	_~	_6.79s	_6.86s	_{p=0.806 n=6}
_{Bind Time}	_{2.28s (± 1.22%)}	_{2.29s (± 0.62%)}	_~	_2.27s	_2.31s	_{p=0.331 n=6}
_{Check Time}	_{60.37s (± 0.39%)}	_{60.38s (± 0.46%)}	_~	_59.98s	_60.79s	_{p=0.936 n=6}
_{Emit Time}	_{0.14s (± 2.95%)}	_{0.14s (± 2.95%)}	_~	_0.13s	_0.14s	_{p=1.000 n=6}
_{Total Time}	_{69.61s (± 0.33%)}	_{69.63s (± 0.39%)}	_~	_69.22s	_70.02s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,317	_1,226,318	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,840	_260,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,418,465k (± 3.43%)}	_{2,369,381k (± 2.61%)}	_~	_2,343,583k	_2,495,921k	_{p=0.810 n=6}
_{Parse Time}	_{7.42s (± 1.06%)}	_{7.47s (± 1.22%)}	_~	_7.33s	_7.60s	_{p=0.378 n=6}
_{Bind Time}	_{2.78s (± 0.89%)}	_{2.78s (± 0.54%)}	_~	_2.77s	_2.81s	_{p=1.000 n=6}
_{Check Time}	_{49.61s (± 1.19%)}	_{49.28s (± 0.55%)}	_~	_48.85s	_49.65s	_{p=0.298 n=6}
_{Emit Time}	_{3.85s (± 3.55%)}	_{3.83s (± 4.90%)}	_~	_3.69s	_4.16s	_{p=0.689 n=6}
_{Total Time}	_{63.68s (± 1.21%)}	_{63.37s (± 0.77%)}	_~	_62.65s	_63.93s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,317	_1,226,318	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_260,840	_260,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,444,561k (± 2.51%)}	_{2,419,247k (± 0.03%)}	_~	_2,418,304k	_2,420,531k	_{p=0.378 n=6}
_{Parse Time}	_{5.16s (± 1.07%)}	_{5.17s (± 1.28%)}	_~	_5.11s	_5.26s	_{p=0.810 n=6}
_{Bind Time}	_{1.71s (± 1.01%)}	_{1.70s (± 0.61%)}	_~	_1.69s	_1.72s	_{p=0.797 n=6}
_{Check Time}	_{34.32s (± 0.26%)}	_{34.33s (± 0.28%)}	_~	_34.21s	_34.48s	_{p=0.936 n=6}
_{Emit Time}	_{2.59s (± 2.86%)}	_{2.62s (± 1.92%)}	_~	_2.55s	_2.70s	_{p=0.521 n=6}
_{Total Time}	_{43.79s (± 0.32%)}	_{43.84s (± 0.28%)}	_~	_43.72s	_44.06s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,026	_258,027	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,904	_104,904	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,927k (± 0.02%)}	_{426,914k (± 0.01%)}	_~	_426,841k	_426,969k	_{p=0.936 n=6}
_{Parse Time}	_{3.32s (± 0.44%)}	_{3.33s (± 1.48%)}	_~	_3.28s	_3.40s	_{p=0.809 n=6}
_{Bind Time}	_{1.32s (± 0.78%)}	_{1.32s (± 1.33%)}	_~	_1.29s	_1.33s	_{p=0.803 n=6}
_{Check Time}	_{17.99s (± 0.51%)}	_{17.98s (± 0.32%)}	_~	_17.87s	_18.03s	_{p=0.809 n=6}
_{Emit Time}	_{1.34s (± 1.60%)}	_{1.34s (± 1.02%)}	_~	_1.33s	_1.37s	_{p=0.213 n=6}
_{Total Time}	_{23.98s (± 0.40%)}	_{23.97s (± 0.21%)}	_~	_23.90s	_24.03s	_{p=0.810 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,862k (± 0.02%)}	_{369,778k (± 0.02%)}	_~	_369,698k	_369,879k	_{p=0.066 n=6}
_{Parse Time}	_{2.36s (± 0.92%)}	_{2.35s (± 1.02%)}	_~	_2.33s	_2.39s	_{p=0.461 n=6}
_{Bind Time}	_{1.33s (± 1.13%)}	_{1.33s (± 0.91%)}	_~	_1.32s	_1.35s	_{p=0.402 n=6}
_{Check Time}	_{13.35s (± 0.48%)}	_{13.33s (± 0.60%)}	_~	_13.22s	_13.41s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{17.04s (± 0.34%)}	_{17.00s (± 0.57%)}	_~	_16.88s	_17.10s	_{p=0.810 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,840,560	_2,840,560	_~	_~	_~	_{p=1.000 n=6}
_Types	_962,642	_962,642	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,013,622k (± 0.00%)}	_{3,013,618k (± 0.00%)}	_~	_3,013,563k	_3,013,751k	_{p=0.575 n=6}
_{Parse Time}	_{17.02s (± 0.30%)}	_{17.07s (± 0.30%)}	_~	_16.97s	_17.12s	_{p=0.173 n=6}
_{Bind Time}	_{5.10s (± 1.77%)}	_{5.10s (± 2.19%)}	_~	_5.03s	_5.33s	_{p=0.936 n=6}
_{Check Time}	_{90.04s (± 2.19%)}	_{89.84s (± 2.20%)}	_~	_88.88s	_93.88s	_{p=0.575 n=6}
_{Emit Time}	_{28.00s (± 6.74%)}	_{28.07s (± 6.92%)}	_~	_24.11s	_29.02s	_{p=0.575 n=6}
_{Total Time}	_{140.17s (± 0.22%)}	_{140.09s (± 0.20%)}	_~	_139.75s	_140.57s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,048	_266,048	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,470	_108,470	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,874k (± 0.02%)}	_{410,833k (± 0.02%)}	_~	_410,757k	_410,963k	_{p=0.575 n=6}
_{Parse Time}	_{3.85s (± 0.31%)}	_{3.85s (± 0.26%)}	_~	_3.84s	_3.86s	_{p=0.865 n=6}
_{Bind Time}	_{1.67s (± 0.83%)}	_{1.67s (± 1.20%)}	_~	_1.64s	_1.69s	_{p=0.568 n=6}
_{Check Time}	_{17.03s (± 0.24%)}	_{16.98s (± 0.39%)}	_~	_16.90s	_17.09s	_{p=0.148 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.55s (± 0.25%)}	_{22.50s (± 0.26%)}	_~	_22.43s	_22.61s	_{p=0.172 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_535,743	_535,743	_~	_~	_~	_{p=1.000 n=6}
_Types	_182,738	_182,738	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{470,440k (± 0.01%)}	_{470,475k (± 0.02%)}	_~	_470,382k	_470,564k	_{p=0.471 n=6}
_{Parse Time}	_{3.95s (± 0.31%)}	_{3.94s (± 0.69%)}	_~	_3.91s	_3.97s	_{p=0.806 n=6}
_{Bind Time}	_{1.49s (± 1.53%)}	_{1.49s (± 0.71%)}	_~	_1.47s	_1.50s	_{p=0.415 n=6}
_{Check Time}	_{22.70s (± 0.66%)}	_{22.67s (± 0.33%)}	_~	_22.56s	_22.77s	_{p=0.630 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.14s (± 0.50%)}	_{28.09s (± 0.31%)}	_~	_27.95s	_28.20s	_{p=0.378 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

ahejlsberg · 2024-05-28T19:31:32Z

Tests are clean and performance is unaffected. I think this one is ready for review and merge.

typescript-bot · 2024-05-28T19:37:50Z

@ahejlsberg Here are the results of running the top 400 repos comparing main and refs/pull/58677/merge:

Everything looks good!

* upstream/main: (37 commits) Added NoTruncation flag to completions (microsoft#58719) Clone node to remove location even when it has been modified if needed (microsoft#58706) Properly account for `this` argument in intersection apparent type caching (microsoft#58677) Fix: Include Values of Script Extensions for Unicode Property Value Expressions in Regular Expressions (microsoft#58615) In `reScanSlashToken` use `charCodeChecked` not `codePointChecked` (microsoft#58727) Shorten error spans for errors reported on constructor declarations (microsoft#58061) Mark file as skips typechecking if it contains ts-nocheck (microsoft#58593) Fixed an issue with broken `await using` declarations in `for of` loops (microsoft#56466) Do not expand type references in keyof and index access (microsoft#58715) Improve the performance of isolatedDeclarations quickfix (microsoft#58722) Unwrap `NoInfer` types when narrowing (microsoft#58292) Recover from type reuse errors by falling back to inferred type printing (microsoft#58720) Fixing self import (microsoft#58718) Enable JS emit for noCheck and noCheck for transpileModule (microsoft#58364) Revert PR 55371 (microsoft#58702) Update dependencies (microsoft#58639) Fix baselines after PR 58621 (microsoft#58705) Do not infer `yield*` type from contextual `TReturn` (microsoft#58621) `await using` normative changes (microsoft#58624) Handling statements from a known source file (microsoft#58679) ...

Properly account for thisArgument in intersection apparent type caching

80eb1f9

typescript-bot assigned ahejlsberg May 28, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 28, 2024

Only use global cache when type and thisArgument differ

8018672

Add regression test

dc620f2

ahejlsberg requested review from DanielRosenwasser and RyanCavanaugh May 28, 2024 19:31

rbuckton approved these changes May 31, 2024

View reviewed changes

DanielRosenwasser approved these changes May 31, 2024

View reviewed changes

ahejlsberg merged commit 6c058d4 into main May 31, 2024
28 checks passed

ahejlsberg deleted the fix58175 branch May 31, 2024 21:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Properly account for `this` argument in intersection apparent type caching#58677

Properly account for `this` argument in intersection apparent type caching #58677

ahejlsberg commented May 28, 2024

ahejlsberg commented May 28, 2024

ahejlsberg commented May 28, 2024

typescript-bot commented May 28, 2024 •
edited

Loading

typescript-bot commented May 28, 2024

typescript-bot commented May 28, 2024

typescript-bot commented May 28, 2024

tsc

typescript-bot commented May 28, 2024

ahejlsberg commented May 28, 2024

typescript-bot commented May 28, 2024 •
edited

Loading

typescript-bot commented May 28, 2024

typescript-bot commented May 28, 2024

typescript-bot commented May 28, 2024

tsc

ahejlsberg commented May 28, 2024

typescript-bot commented May 28, 2024

Properly account for this argument in intersection apparent type caching#58677

Properly account for this argument in intersection apparent type caching #58677

Conversation

ahejlsberg commented May 28, 2024

ahejlsberg commented May 28, 2024

ahejlsberg commented May 28, 2024

typescript-bot commented May 28, 2024 • edited Loading

typescript-bot commented May 28, 2024

typescript-bot commented May 28, 2024

typescript-bot commented May 28, 2024

tsc

typescript-bot commented May 28, 2024

ahejlsberg commented May 28, 2024

typescript-bot commented May 28, 2024 • edited Loading

typescript-bot commented May 28, 2024

typescript-bot commented May 28, 2024

typescript-bot commented May 28, 2024

tsc

ahejlsberg commented May 28, 2024

typescript-bot commented May 28, 2024

Properly account for `this` argument in intersection apparent type caching#58677

Properly account for `this` argument in intersection apparent type caching #58677

typescript-bot commented May 28, 2024 •
edited

Loading

typescript-bot commented May 28, 2024 •
edited

Loading